Major Scroll Speed concern in MovingPictures/TVseries when using Fanart Handler

GoogleCodeExporter commented 8 years ago

We have recently discovered in StreamedMP svn (revision greater than r897)
that speed when scrolling in tvseries/movingpics window has dramatically
been reduced.

I check X-Factor SVN and noticed that slow down also occurs, if you disable
Fanart-Handler.dll then scroll speed is nice and fast.

We are not sure what is the cause, we can reproduce in FH 1.2 and 1.3RC1.
We are not sure what we did in r898 of StreamedMP to expose the issue but
if we disable fh.dll or rename the file common.overlays2.xml (but keep
fh.dll enabled) in streamedmp then the problem disappears.

I can send you a Compiled version of our StreamedMP svn so you can check it
out or you can just point your skin folder to StreamedMP SVN and do a SVN
Checkout.

Would appreciate some help in identifying the issue if its FH.dll, Skin or
bit of both.

Original issue reported on code.google.com by damien.haynes@gmail.com on 5 Feb 2010 at 1:02

GoogleCodeExporter commented 8 years ago

Link to revision history in StreamedMP SVN:
http://code.google.com/p/streamedmp/source/list

Original comment by damien.haynes@gmail.com on 5 Feb 2010 at 1:04

GoogleCodeExporter commented 8 years ago

Just to be clear we dont use FH.dll in MovingPictures or TVSeries so not sure 
why
there could be a slow down. Possibly FH.dll should check what window is top 
most and
if music is playing?

Original comment by damien.haynes@gmail.com on 5 Feb 2010 at 1:05

GoogleCodeExporter commented 8 years ago

extra to this, I have tested the various versions and 1.0 works fine and shows 
no 
slow down everything since does.

Some questions, 

1. if the skin file does not have any fanart defines will FH look at it?
2. does a skin file that FH should not look at have an explict 'No' define to 
indicate this?
3. can you add some debugging (confgurable) to show what FH is actioning?

Original comment by tdnemail on 5 Feb 2010 at 1:25

GoogleCodeExporter commented 8 years ago

hi,

I will look into this. Thank you for your report. Are the delay you see about 
the same 
in the x-factor skin as in SteamedMP?

best regards
cul8er

Original comment by markus_e...@telia.com on 5 Feb 2010 at 7:28

Changed state: Accepted
Added labels: Milestone-1.3
Removed labels: Milestone-TobeDecided

GoogleCodeExporter commented 8 years ago

Thanks cul8er, yes the delay is approx the same.

Original comment by damien.haynes@gmail.com on 5 Feb 2010 at 9:38

GoogleCodeExporter commented 8 years ago

Hi,

Can you please test the attached version ans see if it is better. I have 
optimized 
some code and also made some changes in how the refresh timer works in the 
plugin.

If this version does not work, please try to disable the two scraping options 
in the 
plugin and see if that makes any difference.

best regards
cul8er

Original comment by markus_e...@telia.com on 5 Feb 2010 at 12:58

Attachments:

FanartHandler.rar

GoogleCodeExporter commented 8 years ago

Hi cul8er,

Just tried this and the results are the same, turned off all scaping options, 
even 
deleted all fanart and the result is the same. Disable FH and all is fine and 
runs 
at normal speed.

Thanks

Original comment by tdnemail on 5 Feb 2010 at 2:06

GoogleCodeExporter commented 8 years ago

Very strange, runs normal here (x-factor skin). What MP version are you using? 
What 
views in Moving Picture are slow? Is the effect the same using version 1.1 as 
in 1.2 
and 1.3?

best regards
cul8er

Original comment by markus_e...@telia.com on 5 Feb 2010 at 3:17

GoogleCodeExporter commented 8 years ago

Hi,

What do you mean with this comment "If we rename common.overlays2.xml or 
disable FH.dll 
then its fast again.". Do you mean that if you rename the common.overlays2.xml 
so that 
MP does not find it then scrolling is fast again?

best regards
cul8er

Original comment by markus_e...@telia.com on 5 Feb 2010 at 3:26

GoogleCodeExporter commented 8 years ago

I am running MP1.1beta svn 24923, not sure what version Damian is running. The 
slow 
down appears in list view - MovingPictures (v8 beta) shows the worst slowdown, 
TVSeries is better.

Damien got the file name wrong, is is common.overlays.xml - just 
renaming/deleting 
it out of the way so MP does not find them also solves the problem as does 
putting 
back FH V1.0...all very odd. 

Attached is the overlay file and I tracked to the music controls - I had added 
FH 
code to these but removed it when we had these issues.

I cant see what in this file could be causing issues.

Thanks

Original comment by tdnemail on 5 Feb 2010 at 4:02

Attachments:

common.overlays.xml

GoogleCodeExporter commented 8 years ago

Hi,

So you mena that with the attached version it works ok? Or was it the same with 
and 
witout the FH controls? If so can you please attach the version causing 
problems? Or 
did I missunderstand you?

best regards
cul8er

Original comment by markus_e...@telia.com on 5 Feb 2010 at 4:41

GoogleCodeExporter commented 8 years ago

hi,

Sorry may have confused you there, the file I attached will cause the issue and 
if 
this is renamed/deleted to MP can't load it the issue goes away. 

It should be noted that this file used with the 1.0 release works fine.

Original comment by tdnemail on 5 Feb 2010 at 4:55

GoogleCodeExporter commented 8 years ago

Hi cul8er, as stated by tdnemail the problem with slowdown doesnt occur when 
either
of the following is true:

1. Fanart Handler is disabled
2. Rename or Remove the reference to common.overlay.xml (or common.overlays2.xml
depending on the style chosen in StreamedMP) so it doesnt load with
TVSeries/MovingPictures.

So im guessing there is something processed by the FH.dll when our 
common.overlay.xml
is used

Original comment by damien.haynes@gmail.com on 5 Feb 2010 at 11:06

GoogleCodeExporter commented 8 years ago

Hi,

This is getting stranger and stranger. I have read the attached xml file any 
times 
but cannot find how it can be affected but apparently it is. Can you please try 
the 
attached file and see if it helps. I have limited the use of fanart handler as 
much 
as I can in this version so hopefully it can resolve the issue. Please let me 
know 
how it works.

best regards
cul8er

Original comment by markus_e...@telia.com on 5 Feb 2010 at 11:39

Changed state: NeedsVerification

Attachments:

FanartHandler.rar

GoogleCodeExporter commented 8 years ago

Hi cul8er, thanks for efforts so far in helping solve this problem. Here are my
results with this new DLL.

Speed remains the same ie Slower with FH enabled and faster with FH disabled (Im
going to put in some logging in tvseries so I can give you an idea on the speed
difference).

I think it still might appear fast depending on your CPU, but on average 
DualCore I
think you will notice it a lot more. Im currently testing on a QuadCore i5 
2.8Ghz but
I have a Dual Core2Duo 2.4Ghz on main HTPC which I will test this dll on as 
well for
comparison.

It seems now when I disable the usage of the overlay code it makes no 
difference now
so it just seems if the DLL is enabled or disabled now when speed drop occurs. 
Trevor
can you confirm on your end?

My Tests have included disabling all Scraper options but made no difference. I 
will
also run some performance stats on X-Factor as well when I get a chance.

Original comment by damien.haynes@gmail.com on 6 Feb 2010 at 2:17

GoogleCodeExporter commented 8 years ago

Here is some Stats on my Faster Dev PC:

2secs vs 6secs

Original comment by damien.haynes@gmail.com on 6 Feb 2010 at 2:29

Attachments:

GoogleCodeExporter commented 8 years ago

I couldnt reproduce TVSeries facade slowdown with X-Factor but I tried 
MovingPictures
in X-Factor and was 4secs vs 6secs.

But this is on a faster pc, so really need to run on a system that will be 
fairly
common which I have in the living room (even though its still relatively fast).

Original comment by damien.haynes@gmail.com on 6 Feb 2010 at 3:05

Attachments:

GoogleCodeExporter commented 8 years ago

In StreamedMP MovingPictures its much worse: 5secs vs 54secs

Note: All these steps involve holding down the DownArrow on keyboard when 
entering
the facade.

Original comment by damien.haynes@gmail.com on 6 Feb 2010 at 3:31

Attachments:

GoogleCodeExporter commented 8 years ago

So I did some tests to narrow down issue in StreamedMP and got to a point where 
I
edited mymusicgenres.xml, mymusicsongs.xml and mymusicplaylist.xml such that all
defines are set to off like so:

<define>#usePlayFanart:no</define>
<define>#useSelectedFanart:no</define>
<define>#useRandomMusicFanart:no</define>

And MovingPictures scrolling is much faster! But why?

Original comment by damien.haynes@gmail.com on 6 Feb 2010 at 8:36

GoogleCodeExporter commented 8 years ago

Hi,

Thanks for all this information. I still cannot find why this happens but will 
make a 
new run tonight.

One question. Do you have music or movie playing or stopped when this happens?
best regards
cul8er

Original comment by markus_e...@telia.com on 6 Feb 2010 at 1:07

GoogleCodeExporter commented 8 years ago

Hi,

Why do the moving picture log contains these extra lines when FH is enabled;
06-Feb-2010 14:26:57 Debug [   MovingPicturesGUI]: Publishing Movie Artwork 
06-Feb-2010 14:26:57 Debug [        MovieBrowser]: SelectedMovie changed: 
Boundin'

Do you have an idea? What does these lines means?

cheers
cul8er

Original comment by markus_e...@telia.com on 6 Feb 2010 at 1:14

GoogleCodeExporter commented 8 years ago

Hi Cul8er, I dont have anything playing when doing these tests. Basically I 
restart
mediaportal and go straight into the plugin and start scrolling.

With respect to the those extra log lines when FH is enabled is due to the much
slower response when scrolling. Fields are only published to the skin if you 
are on
an item for more than 250ms which is the case here. I don't see it when FH is
disabled because it can scroll faster through each item.

Original comment by damien.haynes@gmail.com on 6 Feb 2010 at 2:10

GoogleCodeExporter commented 8 years ago

Hi,

Thank you for the explanation. I have an idea of what might cause this but to 
test it 
properly, is it possible for you to zip a StreamedMP file for me to use as this 
is 
the skin showing most slowdown according to your numbers above. This would help 
me 
alot when testing and I don't have to ask you for new tests all the time.

best regards
cul8er

Original comment by markus_e...@telia.com on 6 Feb 2010 at 2:39

GoogleCodeExporter commented 8 years ago

Hi,

Do you know if the two things is possible from a plugin (and how to code it);
1. Register an event that is fired when MP play next track (music starts or 
plays 
next track)
2. Register an event that is fired when a new window is open (for example user 
is in 
basichome and opens moving picture).

If any of the above was possible (I don't know MP that good yet :( ) that would 
make 
this plugin so much more efficient.

best regards
cul8er

Original comment by markus_e...@telia.com on 6 Feb 2010 at 2:53

GoogleCodeExporter commented 8 years ago

For Player handling try MediaPortal.Player.g_Player, it has:

g_Player.PlayBackStopped += new
MediaPortal.Player.g_Player.StoppedHandler(OnPlayBackStopped);

g_Player.PlayBackEnded += new 
MediaPortal.Player.g_Player.EndedHandler(OnPlayBackEnded);

g_Player.PlayBackStarted += new
MediaPortal.Player.g_Player.StartedHandler(OnPlayBackStarted);

For Window management try the MediaPortal.GUI.Library namespace:

GUIWindowManager.OnActivateWindow += new
GUIWindowManager.WindowActivationHandler(GUIWindowManager_OnActivateWindow);

GUIWindowManager.OnDeActivateWindow +=new
GUIWindowManager.WindowActivationHandler(GUIWindowManager_OnDeActivateWindow);

Original comment by damien.haynes@gmail.com on 6 Feb 2010 at 3:16

GoogleCodeExporter commented 8 years ago

I will send you a pm with address to download a setup for StreamedMP.

Original comment by damien.haynes@gmail.com on 6 Feb 2010 at 3:31

GoogleCodeExporter commented 8 years ago

Original comment by markus_e...@telia.com on 6 Feb 2010 at 11:15

Changed state: Started

GoogleCodeExporter commented 8 years ago

Hi,

Just to let you know that I'm working on this and will not make a release until 
this 
issue is solved. Is currently re-writing parts of the plugin to solve this. 
Moving from 
timer based to event based. Will make the plugin better in every aspect.

best regards
cul8er

Original comment by markus_e...@telia.com on 6 Feb 2010 at 11:48

Added labels: Priority-Critical
Removed labels: Priority-Medium

GoogleCodeExporter commented 8 years ago

awesome news cul8er!

Original comment by damien.haynes@gmail.com on 6 Feb 2010 at 11:55

GoogleCodeExporter commented 8 years ago

Hi,

Some progress. Please test the attached version and see if it helps. If music 
is not 
playing the fanart handler plugin should do nothing when in moving picture or 
other 
screens that doesn't have the fanart define tags.

best regards
cul8er

Original comment by markus_e...@telia.com on 8 Feb 2010 at 12:00

Attachments:

FanartHandler.rar

GoogleCodeExporter commented 8 years ago

It's looking good cul8er, I only tested the scrolling though :) Will do more 
testing
later.

Good Job!

Original comment by damien.haynes@gmail.com on 8 Feb 2010 at 2:06

GoogleCodeExporter commented 8 years ago

Hi,

Thank you for all your help and support. Please let me know when you are done 
testing 
so I know if I can close this issue.

best regards
cul8er

Original comment by markus_e...@telia.com on 8 Feb 2010 at 3:04

Changed state: NeedsVerification

GoogleCodeExporter commented 8 years ago

Just tested here and the issue with slow scolling look fixed, I will test out 
the 
rest of the funtions.

Send the Good Job..

Thanks

Original comment by tdnemail on 8 Feb 2010 at 10:08

GoogleCodeExporter commented 8 years ago

I think this issue can be closed, if there is any issues found with respect to 
new
changes we can raise as separate issues as the original problem is resolved.

Thanks.

Original comment by damien.haynes@gmail.com on 8 Feb 2010 at 10:14

GoogleCodeExporter commented 8 years ago

Thanks for all your help and support in resolving this issue. 

best regards
cul8er

Original comment by markus_e...@telia.com on 9 Feb 2010 at 6:58

Changed state: Done

phbusfan / fanart-handler

Major Scroll Speed concern in MovingPictures/TVseries when using Fanart Handler #55