phbusfan / fanart-handler

Automatically exported from code.google.com/p/fanart-handler
0 stars 0 forks source link

Download Max Images Per Artist option not working #98

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Hi!

Using version 2.2.0 Beta 3.
I realized that even thou the Download Max Images Per Artist option is set to 
10 only 4 backdrops are scraped.

I've seen this with artist 'Dendemann' and 'Dynamite Deluxe' which both have 7 
direct matches on htbackdrops.

Cheers
Jayhunter

Original issue reported on code.google.com by jayhun...@gmx.net on 8 Oct 2010 at 8:45

GoogleCodeExporter commented 8 years ago
Just realized the final 2.2.0 got released. Thist bug still apllies to the 
final.

Original comment by jayhun...@gmx.net on 9 Oct 2010 at 5:21

GoogleCodeExporter commented 8 years ago
Hi,

Is this related to scraping for now playing media or the "initial" scrape for 
an artist? If it is related to now playing scrape then yes, I have a limit for 
max four images. The reason is that I do not want to overload the htbackdrop 
site.

Please let me know.

best regards
cul8er

Original comment by markus_e...@telia.com on 9 Oct 2010 at 11:23

GoogleCodeExporter commented 8 years ago
Ah!

It was indeed only the now playing scrape that is limited. Initial scrape did 
go to the max. It gives me 2 questions thou ..

1. If I only enable 'download for now playing' but not the 'download for 
artists in my database' option, I will never get to the download max images 
setting if it's >4?

2. I think overloading htbackdrops will more likely happen during initial 
scrapes. I just saw my own hammering on the server with ~4 request/sec for 
quite some time. If many people do that simultaniusly for a few 1000 artists 
(which could happen tonight .. it's saturday and the new plugin got released :) 
it's way more intense one the server than a stady load. So there is no need to 
worry about the now playing scrape I think. Planty of resources left if we get 
through the inital scrapings ...  :)

Cheers
Jayhunter

Original comment by jayhun...@gmx.net on 9 Oct 2010 at 1:32

GoogleCodeExporter commented 8 years ago
Hi,

If you think it is ok I will remove the four image limit (only did it to be 
kind to your server). I will do this in next. Version. Thanks.

best regards
cul8er

Original comment by markus_e...@telia.com on 10 Oct 2010 at 6:29

GoogleCodeExporter commented 8 years ago

Original comment by markus_e...@telia.com on 11 Oct 2010 at 6:28