phcode-dev / phoenix

Phoenix is a modern open-source Code Editor for the web, built for the browser.
https://phcode.io
GNU Affero General Public License v3.0
1.68k stars 117 forks source link

Stability: Node crash on computer sleep - below our stability target #1791

Closed abose closed 1 month ago

abose commented 1 month ago

Describe the bug

About 10% of total desktop userbase is affected from metrics . So marking as high priority to address before next release.

Problem report:

From what I can tell, every time my computer (Dell running Windows 10) goes into sleep mode, when I wake it and return to Phoenix Code (desktop), I get an "Oops! Something went wrong!" message with the error code ERROR_NODE_JS_CRASH. This wasn't the case when I first installed the Phoenix desktop app, it started in May or June, and I can't think of anything that changed in my environment. Has anyone else seen this, or does anyone have any ideas to solve this issue?

See: https://github.com/orgs/phcode-dev/discussions/1790

This is only a problem in desktop builds and should not be limited to just windows OS.

Reproduction

sleep and awake with phoenix open

Expected behavior

no node crash

OS, Browser and Phoenix versions

All desktop versions

Metrics for node.crash.dlgShown

image

souscrire commented 1 month ago

I've had this problem on two machines running windows 10. When will this be fixed please?

abose commented 1 month ago

@souscrire The issue is fixed and should be available in the release planned for this week.