search

phcode-dev / phoenix

Phoenix is a modern open-source Code Editor for the web, built for the browser.
https://phcode.io
GNU Affero General Public License v3.0
1.79k stars 124 forks source link

fix: node crashes after computer sleep #1823

Closed abose closed 2 months ago

abose commented 2 months ago

Fixes https://github.com/phcode-dev/phoenix/issues/1791

Node exited after sleep as web sockets gets disconnected at sleep, and our orphan exit timer will inccorectly determine that too much time has passed including the time the app was asleep and terminated node.

We dont need orpahn exit timers anymore as node is terminated oon stdio disconnect, which is a much more reliable way to detect process exit. We did not remove this code at node connector as it maybe a miss during the algo change?

phoenixide commented 2 months ago

Thank You for making this pull request.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud