search

phcode-dev / phoenix

Phoenix is a modern open-source Code Editor for the web, built for the browser.
https://phcode.io
GNU Affero General Public License v3.0
1.64k stars 115 forks source link

Debug menu is empty after restarting without extensions #1847

Open nmalinoski opened 6 days ago

nmalinoski commented 6 days ago

Describe the bug

When reloading without extensions, the app reloads successfully; however, while the Debug menu is still present, it's empty.

Reproduction

  1. Select Debug > Reload Without Extensions
  2. Click on the Debug menu item

Expected behavior

This may be due to my ignorance in how the Debug menu is implemented, but I would have expected there to be something in this menu; at least the Reload With Extensions option, maybe also the Chrome Developer Tools menu.

Or the Debug menu should be removed altogether if there's nothing in it; it doesn't make sense to me why the UI would offer an empty menu like that.

OS, Browser and Phoenix versions

  1. Windows 10 x64
  2. Phoenix Code 3.9.4 for Windows x64

logs or debug stack trace if any

No response

Additional context

No response

abose commented 5 days ago

Thanks for reporting the issue @nmalinoski . The debug menu in phoenix is a feature carried over from Brackets and its main intent was to debug Phoenix itself. This was confusing and we moved a lot of those features into a Phoenix Code Diagnostic Tools submenu in debug as we prepare to integrate more debug tools into Phcode.

Note to future fix

This will be address in the coming releases, but this specific issue of reload without extensions may need to be reworked to prevent user confusion. We should split this into two options:

1.Reload phoenix code core only option inside Phoenix Code Diagnostic Tools sub menu

  1. Reload without extensions option should only reload without any user installed extensions. all core extensions should be loaded as that will be a user facing top level option.