"Stop" button doesn't work and old settings not correctly imported

[ThaTim]

In version 1.1.0. the Stop button, when scanning for subtitles (the first scan screen) doesn't work.

Also, I've imported my settings from the old BETA and suddenly the program searched for subs in other maps within my selected map. I didn't checked this box in the old BETA and I didn't checked the box in the new BETA. When I selected my main map again and left the checkbox (search maps within maps) unchecked, it worked.

[phdelodder]

Can't reproduce the old settings imported, tried from different versions but no success.

The stop is implemented by @RobinHoutevelts I'll have a closer look on it

[RobinHoutevelts]

This bug ( Stop button not working at file indexing ) got introduced in BETA4. It (sorta) works in BETA3.

BETA4 was a big release ( https://github.com/phdelodder/SubTools/compare/subtools-1.0.0-BETA3...subtools-1.0.0-BETA4 ) so it might take a while to track this down.

I do suggest you sprinkle a few checks across while loops to stop if the Thread was interrupted.

while(!Thread.currentThread().isInterrupted() && <normal condition>)

Because AFAIK pressing cancel currently only hides the indexing instead of actual quitting.

I'll try to find some time tomorrow to look into this.

[ThaTim]

Update on the "old settings" issue: I've set my program to search in a specific map, without looking in sub-maps. Every time I start the program, I have to re-set this setting. So it's not only happening at importing settings from old versions.

[phdelodder]

Can you provide screenshots and a prefs file?

Or a movie file where you show what you are doing. I can't simulate it, so need more input

[ThaTim]

I've attached a screenshot where you can see that the program is searching for 301 subs. My map, including sub-maps, contains 301 files. My map, without the sub-maps, contains 90 files. You can see clearly that the checkbox "mappen in map doorzoeken" is unchecked. My "locatie nieuwe afleveringen" map is my standard map (which works fine). So the only problem is that the program searches in sub-maps, every time I start the program again. When I change the "mappen in map doorzoeken" setting it's keeping those settings for that one time only.

[phdelodder]

Can you give me the version and a trace log? You can enable it by adding --trace when you start the tool or change info to trace in the logging part. I also need you settings if possible?

[ThaTim]

I've added the first part of my trace here https://dl.dropboxusercontent.com/u/59140105/trace%20multisub.txt Please note: E:\Emule Incoming is my standard map My settings: https://dl.dropboxusercontent.com/u/59140105/voorkeuren%20multisub%20beta.xml

[Wally73]

have you deleted the cache folder before you upgraded to newer version?? i've had the not remembering scanning in subfolders either but that has been fixed (at least on my comp it works as it should)

On Thu, Mar 5, 2015 at 8:16 PM, ThaTim notifications@github.com wrote:

I've added the first part of my trace here https://dl.dropboxusercontent.com/u/59140105/trace%20multisub.txt My settings: https://dl.dropboxusercontent.com/u/59140105/voorkeuren%20multisub%20beta.xml

— Reply to this email directly or view it on GitHub https://github.com/phdelodder/SubTools/issues/70#issuecomment-77431153.

[phdelodder]

@ThaTim https://www.dropbox.com/s/go6x9ex3zw7s03t/multisubdownloader-1.1.0-SNAPSHOT-jar-with-dependencies.jar?dl=0

This is the latest build have done a few fixes can you retry it? if you have the same issue give the log with trace but I need the "getFileListing" line of the log. Thats is the most important one!

[ThaTim]

I've deleted my cache folder several times. Yesterday was the last time, but the issue wasn't hoping away.

I'll try the latest build

[ThaTim]

It looks like the issue is gone. Thanks.

I do get this error: Error: API JAddic7ed searchSubtitles using title: java.lang.NullPointerException

Is this something I have to fix myself or not?

[phdelodder]

@ThaTim I need to know more a debug would be nice of the error and maybe the release

[ThaTim]

The error does not occur anymore, so I think it was an error caused by the Addicted database