phdsg / PvC

PvC Modules for VCVRack
BSD 3-Clause "New" or "Revised" License
24 stars 1 forks source link

Added shift register #1

Closed fenykep closed 6 years ago

fenykep commented 6 years ago

I'm new to github, and also not a programmer, so I've used your code as a base -if you don't mind. Can I add this module to your repo, or do you want me to create a separate one? Thanks for the base code.

phdsg commented 6 years ago

i'm probably even newer to this git thing or programming. don't know how to handle pull requests. better do this under your own name. "my" code is only c&p from unity (i think it was). i cloned and compiled your shiftie, but i'm not sure what it does and what the lights are presenting. at some point the lights just don't go off anymore.

fenykep commented 6 years ago

Okay, I'll try to separate it and write some documentation for it. Can I use your graphics though? It would be really hard for me to start designing a plate from scratch. The upper trigger input increases the output value and the lower one decreases it.

phdsg commented 6 years ago

sure you can use the svg. although making your own or editing one isn't that hard.