search

phe-sto / enthic

French societies accountability extraction and treatment by PapIT
https://api.enthic.fr/
Do What The F*ck You Want To Public License
8 stars 1 forks source link

Is sh/database-creations.sh still compatible with recent MySQL 8 versions #19

Closed phe-sto closed 3 years ago

phe-sto commented 3 years ago

I had to replace all "$1" by --password="$1"; on my machine that as a quite recent version of MySQL 8. Version is: mysql Ver 8.0.23-0ubuntu0.20.04.1 for Linux on x86_64 ((Ubuntu)) Is it more safe in all case to have --password="$1" in sql commands? I cannot recall why we just had "$1" do you? I just guess it was working fine older version of MySQL 8.

leonarf commented 3 years ago

If I recall correctly, I didn't modify the way we pass password to sql command. For what it worth, I prefer having "--password=" written than it being implicite. I think it's easier to understand. But I cannot say if it's safer or not. Feel free to commit this change to the code, I handle to you this issue :-)

phe-sto commented 3 years ago

That is what I recall too. We will have to create a PR.