Major housekeeping - Githubissues

phegman / vue-mapbox-gl

A Vue.js component for Mapbox GL JS

GNU General Public License v3.0

270 stars 33 forks source link

Major housekeeping #67

Closed vinayakkulkarni closed 5 years ago

vinayakkulkarni commented 5 years ago

This pull request has the following changes

[x] upgrade babel from 6 to 7
[x] upgrade webpack from 2 to 4
[x] add editorconfig for maintaining code standards
[x] update the coding style in the template, uses Vue's recommended style
[x] add VueLoaderPlugin() which is required in webpack 4 configuration
[x] upgrade dev dependencies. uses all the latest technologies.

vinayakkulkarni commented 5 years ago

@phegman : Any comments / suggestions / thoughts?

vinayakkulkarni commented 5 years ago

Bump

vinayakkulkarni commented 5 years ago

🛎

phegman commented 5 years ago

Thanks! I'll try and take a look at this in the next week or so. I am (slowly) working on rewriting this plugin in TypeScript and streamlining the build/dev config. I may try and merge this in the meantime but need to do some testing on it first to make sure everything is still working as expected.

vinayakkulkarni commented 5 years ago

Do take a look @ https://soal.github.io/vue-mapbox/

Also this: https://github.com/soal/vue-mapbox/issues/111

phegman commented 5 years ago

Closing this out as I have released v2.0.. I appreciate the help though! Feel free to open a PR for anything related to the recent v2.0. release