search

phenaproxima / starshot-prototype

Prototype of a new kind of Drupal, based on recipes and loaded up with contrib's best modules and themes. Not a fork or a distribution.
https://drupal.org/starshot
115 stars 46 forks source link

Defunct "Blog" view #105

Closed TravisCarden closed 2 months ago

TravisCarden commented 3 months ago

There's a "Blog" view at /blog that, as far as I can tell, is defunct. If so, let's delete it.

phenaproxima commented 3 months ago

Recipes cannot delete anything, but we could disable the view by setting its status to false.

TravisCarden commented 2 months ago

Then I propose we disable it. It's actually having (what I assume is) an unintended effect in that it's getting detected and inserted into the breadcrumb on blog post nodes, c.f. related https://github.com/phenaproxima/starshot-prototype/issues/133.

phenaproxima commented 2 months ago

What if we went the opposite way, and embraced this view, with hackable URLs, for an automatic blog archive functionality?

TravisCarden commented 2 months ago

I can get onboard with that, as long as it's not incompatible with the whole goal of recipes being installable on an existing site, such that updating this view would potentially break existing functionality for users who are actually using it.

phenaproxima commented 2 months ago

For now, if the blog view is on an existing site, it would conflict. This is largely because we don't have config actions for views yet (and creating those will be a bear because views are...complicated, at best).

That said, I don't know if any (or even all) Starshot recipes are idempotent. Worth testing separately, but I'm not sure that should block this, since the prototype is meant as a starting point anyway.

TravisCarden commented 2 months ago

True. Seems like a detail that could easily be changed later. I say "go". 🙂

phenaproxima commented 2 months ago

Closing based on https://github.com/phenaproxima/starshot-prototype/issues/133#issuecomment-2246783533.