phenaproxima / starshot-prototype

Prototype of a new kind of Drupal, based on recipes and loaded up with contrib's best modules and themes. Not a fork or a distribution.
https://drupal.org/starshot
118 stars 46 forks source link

Hide "Promotion options" node fields where they're not used #130

Open TravisCarden opened 4 months ago

TravisCarden commented 4 months ago

Every node edit form in Drupal has a "Promotion options" fieldset containing "Promoted to front page" and "Sticky at top of lists" fields, but they don't automatically do anything. And they don't have help text explaining what effect they do have even when they are used. We're using them on "Blog post" but not elsewhere. We should hide them any time they're unused and consider adding help text explaining the effect they'll have when where are used.

phenaproxima commented 4 months ago

I'm okay with hiding these from the Page and Event content types for now, since they are, as you point out, not used.

boulaffasae commented 4 months ago

"Promoted to front page" and "Sticky at top of lists" fields are actually utilized in our Frontpage view configuration (/admin/structure/views/view/frontpage). Specifically:

Given this configuration, I would advise against hiding these options. Removing them would require us to reconfigure the front page view to adjust or remove both the filter and sort criteria. These fields are potentially useful, and we might want to keep them available for future use.

phenaproxima commented 4 months ago

I agree with you, @boulaffasae. I sort of doubt that these fields are causing enough clutter to be worth hiding.

TravisCarden commented 4 months ago

I'm not sure I was fully understood. Let me try to be really unambiguous: I'm only talking about hiding the fields on the node edit screen of content types where they're not used. I'm not talking about disabling the feature so it can never be used anywhere or changing how views are configured. I'm not talking about hiding the fields everywhere they appear. The problem I'm highlighting is that there are user-facing forms where those fields appear but don't do anything, leading to a confusing experience for content authors and site builders. It doesn't make sense to promote a "Basic page" to the front page or make it sticky at the top of lists. Hence I think we should hide them on that specific form display.

boulaffasae commented 3 months ago

Hi Travis, yes sure it should be okey to hide them from specific content types that we think no one will be using them.