search

phenaproxima / starshot-prototype

Prototype of a new kind of Drupal, based on recipes and loaded up with contrib's best modules and themes. Not a fork or a distribution.
https://drupal.org/starshot
118 stars 46 forks source link

Add a recipe for useful authoring-focused accessibility tools #142

Closed thegbomb closed 4 months ago

thegbomb commented 4 months ago

To add some functionality to assist with accessibility I am adding some modules to starshot and making some basic settings changes to improve things.

This is a WIP to share code and progress things to a stable state

thegbomb commented 4 months ago

I have removed other changes which can be dealt with elsewhere, but have left just the editoria11y module being added in this PR. TBD what happens to it elsewhere. I have added it to project_browser, but it will not get installed by default.

phenaproxima commented 4 months ago

One typo suggestion, but otherwise I'm good with this. Nice work. I would like to consult with @timplunkett before merging just so that I can be sure that landing this will align with the defined work tracks for Starshot, and grease the wheels for further contribution.

phenaproxima commented 4 months ago

I personally have no objection to this, the recipe looks good and ready to me, but I think @pameeela and @timplunkett (from the leadership team) have some hesitation about adding additional modules to the prototype, even if they are likely to be in the final product. I suspect they're trying to avoid a "ready, fire, aim" situation.

For that reason, I'm assigning this to @pameeela to make the final call and merge it. But for my part, I endorse this pull request. :)

pameeela commented 4 months ago

Happy to merge so folks can play around with it easily, I think it's clear that something being in the prototype doesn't imply it will be in the product and @thegbomb is across this. In this case, it's not just adding a module for the sake of it, it's actually providing something that it could be good to get feedback on.