search

phenaproxima / starshot-prototype

Prototype of a new kind of Drupal, based on recipes and loaded up with contrib's best modules and themes. Not a fork or a distribution.
https://drupal.org/starshot
118 stars 46 forks source link

Use recipes' ability to borrow values from existing config to set up the Nominatim geocoder #143

Closed phenaproxima closed 4 months ago

phenaproxima commented 4 months ago

Part of why Starshot needs an install profile is to run a function that configures the Nominatim geocoder with a user agent and referer.

Once https://www.drupal.org/project/distributions_recipes/issues/3303126 lands, recipes will have the ability to use existing config values as ephemeral tokens, thus obviating the need for that function. Why wait, though? We can patch core. I propose we do just that, with an abbreviated patch from that issue (we don't need the tests), and trim the install profile down a bit. This brings us a step closer to being able to install Starshot at the command line without using the profile at all.

gitressa commented 4 months ago

This is fantastic, and another example of a needed feature in Starshot accelerating innovation in Drupal core, which will eventually result in amazing future features. Thanks @phenaproxima!

phenaproxima commented 4 months ago

Thanks @gitressa. This is using an earlier iteration of the patch, but I don't think that matters too much; once the feature lands upstream, I can update the patch and the recipes as needed.