Update ddev.yml to fail when quickstart fails

phenaproxima / starshot-prototype

Prototype of a new kind of Drupal, based on recipes and loaded up with contrib's best modules and themes. Not a fork or a distribution.

https://drupal.org/starshot

118 stars 46 forks source link

Update ddev.yml to fail when quickstart fails #144

Closed jjroelofs closed 4 months ago

jjroelofs commented 4 months ago

ddev quick-start is set up to not fail when one of its component scripts, like drush site-install fails
This change addresses this by forcing an error code on the quick-start script when of of its components fail

I'm not sure whether this is by design and I understand the main.yml script also checks the site-install process, I just thought it was weird this script will not fail when the installation process has errors.

phenaproxima commented 4 months ago

🤔 This is only changing our CI workflow. Wouldn't we want to change the .ddev/commands/host/quick-start script?

But I agree we do want to change this, quick-start should fail overall if any step of it does.

jjroelofs commented 4 months ago

I'm just learning the ropes of ddev while exploring starshot, I'll explore that and update this PR if I have a cleaner solution, thx @phenaproxima

jjroelofs commented 4 months ago

@phenaproxima updated