Open mayankguptadotcom opened 5 months ago
Few other important ones that should be included -
Another thing that I noticed was that when I pasted a youtube link in ckEditor demo over here - https://ckeditor.com/docs/ckeditor5/latest/examples/builds-custom/full-featured-editor.html
It embedded the video directly, rather than me to create a remote video. There may be benefits to include remote video as a content type, however - I believe that content editors for marketing purpose will not really care about that in majority of the cases. So I'd rather suggest supporting this kind of embedding with in the ckEditor more.
I am +1 on adding the oEmbed Providers module, but I think we should carefully select which providers we enable. It's really easy to go overboard, and we also need to group the providers into particular media types that make sense.
So I'd propose in this issue we discuss and agree on which providers should be supported, and in which media types (including ones that might not exist yet) -- let's say a maximum of, like, 6 providers, to avoid overwhelm.
Absolutely agreed. Definitely not a huge list - but the most used ones in real world scenarios. Here's my suggested list -
Not sure if Google docs & Github offer oEmbed (the chances are they don't based on my initial research), although embedly seems to (paid service) allow to embed them as well. If we can't do Google docs & Github due to technical limitations then its okay - in that case we have the 6 providers that you are suggesting.
The oEmbed Providers module would be honored!
I'm thinking Starshot could define its own provider bucket, along with any providers that aren't included in providers.json from oembed.com
Isn't Spotify more popular than SoundCloud? And what about X (former Twitter)?
At this point, remote video is a media type that offers YouTube & Vimeo out of the box. However, if we are focused on Marketers, editors and non-developers - then support for more external oEmbed providers will be important for the goal that we want to achieve. WordPress supports multiple oEmbed providers by default and here's a list of those -
I'm not saying that we need to support these to compete against WordPress - but we should support more than YouTube & Vimeo, it should certainly help improve the usability for editors. One module that does a great job to extend the support for various oEmbed providers is https://www.drupal.org/project/oembed_providers