Set the front page title

phenaproxima / starshot-prototype

Prototype of a new kind of Drupal, based on recipes and loaded up with contrib's best modules and themes. Not a fork or a distribution.

https://drupal.org/starshot

106 stars 36 forks source link

Set the front page title #60

Closed TravisCarden closed 2 months ago

TravisCarden commented 2 months ago

The front page title is currently "| Drupal" (by reason of whatever train of default values). Why don't we just set it to "Drupal" ([site:name]), so it looks finished.

TravisCarden commented 2 months ago

Nope. Metatag's default front page config doesn't specify a "Title" value at all:

langcode: en
status: true
dependencies: {  }
id: front
label: 'Front page'
tags:
  canonical_url: '[site:url]'
  shortlink: '[site:url]'

phenaproxima commented 2 months ago

Oh...joy.

Well, in that case, I think this looks good, but I would only request that you update the test coverage to confirm that the title is what we expect it to be.

TravisCarden commented 2 months ago

There--I just expanded the entire test suite by like 20%. 😉 Thanks.