phenaproxima / starshot-prototype

Prototype of a new kind of Drupal, based on recipes and loaded up with contrib's best modules and themes. Not a fork or a distribution.
https://drupal.org/starshot
115 stars 46 forks source link

Considerations for the current Event content type #64

Open mandclu opened 4 months ago

mandclu commented 4 months ago

As someone who has had a lot of conversations with site builders working with dates and times over the years, I thought I would share so initial reactions from the current Event content type in the Starshot prototype:

I'd be happy to provide a PR for any or all of the suggestions above, but thought I would gauge the level of interest/agreement first

phenaproxima commented 4 months ago

a common requirement is a view that list upcoming events, typically ordered by start date (ascending). Often there is a companion display of past events, and a block display of the upcoming events. I would suggest that this be included in the recipe

I think that's a great idea - let's also expose a link in the main menu. I'd happily merge a PR for this, if you submit one. Let's have the starshot_event_content_type recipe package all of this up so that it just works as soon as you apply the recipe.

currently the date field is last in the form, even though it is the only required field, and often one of the most important data points for an event. I would suggest that the date field be first both in the form and the display

Happy to consider a PR for this. Can you make a separate PR, though, so that I can see the result on Tugboat before merging?

personally I prefer to call the date field "When" to more explicitly communicate the relevance, but this is a very minor point

Let's leave this as-is for now; it's trivial to rename.

the prototype currently uses the "default" Smart Date widget, even though for legacy reasons the Smart Date module actually defaults to a newer version, the Inline widget, designed to resemble popular calendar software

😲 I didn't even realize this! By all means, let's have a PR for this.

currently the date field provides no default value, which means that all of the start date and time pieces need to be manually provided a value, even if zero. If the field was a Smart Date field instead of a datetime range field, it could use a "next hour" default, which often reduces the amount of input required and also aligns with how popular calendar software tends to work

💯 agreed on a default value of "now". Can you submit a PR?

I think these are all common sense no-brainer improvements, and I don't think we need to wait for broad agreement to merge these things.

mandclu commented 4 months ago

Sounds great, I can work on some PRs for these. It sounds like we need three:

Is there a preference on the order in which I work on these?

phenaproxima commented 4 months ago

No preference, no deadline. :) Whatever you do, is appreciated!

simesy commented 4 months ago

I supprot smart date and we should use the recurring field in it to avoid this issue being a blocker (to me, probably not that critical): https://www.drupal.org/project/drupal/issues/2794481

timplunkett commented 2 months ago

Let's continue discussion on https://www.drupal.org/project/starshot/issues/3454547 (and any sub-issues)

TravisCarden commented 2 months ago