search

phenaproxima / starshot-prototype

Prototype of a new kind of Drupal, based on recipes and loaded up with contrib's best modules and themes. Not a fork or a distribution.
https://drupal.org/starshot
106 stars 36 forks source link

The Event content type should use Smart Date fields, not datetime_range #69

Closed mandclu closed 2 weeks ago

mandclu commented 1 month ago

As per the discussion in #64, convert the Event content type to use a Smart Date field, and set the default value to "next hour".

phenaproxima commented 1 month ago

Just FYI -- I cannot merge this because it's not installing. This is the error we're getting: https://github.com/phenaproxima/starshot-prototype/actions/runs/9071250306/job/24967409796?pr=69#step:5:791

Probably some misconfiguration in the fields. @mandclu, if you can address this I or another maintainer can manually test and hopefully merge this.

mandclu commented 1 month ago

OK I'll try to have a look tomorrow

mandclu commented 1 month ago

I believe the issue was the field values in the demo content. I added a commit to convert them.

phenaproxima commented 1 month ago

Looks like there's a bug in the module here, @mandclu...bad enough that it prevents installation. Can you address that? I'll need to at least manually test this before I can merge it.

mandclu commented 1 month ago

I added a commit and then tested the result on a fresh install. The updated recipe worked without issue for me.

phenaproxima commented 2 weeks ago

I think this needs to be rebased against main.