search

phenaproxima / starshot-prototype

Prototype of a new kind of Drupal, based on recipes and loaded up with contrib's best modules and themes. Not a fork or a distribution.
https://drupal.org/starshot
106 stars 36 forks source link

Consider adding `easy_responsive_images` #72

Open syzygy333 opened 1 month ago

syzygy333 commented 1 month ago

Forgive me if this isn't the right place for this.

I can't think of a site that I haven't used easy_responsive_images on in years.

syzygy333 commented 1 month ago

The base config could provide some sensible defaults like 16:9 4:3 3:2 1:1

phenaproxima commented 1 month ago

This is absolutely the right place to discuss including this module in Starshot. :)

I certainly trust the author of the module (a fantastic media system co-maintainer), but I'd ideally like to see if anyone else is using this, or just collect a few more opinions about adding it. From reading the project page, I'm a bit concerned that this will generate a slew of extra image styles, which seems a bit pointless for Starshot since we can ship whatever config we want. But I'm certainly open to the possibility.

roromedia commented 1 month ago

If the module would have some sort of undo functionality it would be maybe handy, otherwise it is a pain to remove all generated styles by hand if someone mistyped something or needs to switch breakpoints. In general I would also suggest to have sensible defaults preconfigured for responsive images out of the box - but again they should be removable also very easy - I am using TailwindCSS in all projects so I got the frameworks breakpoints from sm to 2xl for responsive images. If the defaults wouldn't be compatible I would need a quick way to change that. Maybe different recipes for different frontend frameworks as an addon to quickly swap existing defaults?