search

phenaproxima / starshot-prototype

Prototype of a new kind of Drupal, based on recipes and loaded up with contrib's best modules and themes. Not a fork or a distribution.
https://drupal.org/starshot
106 stars 36 forks source link

Install Project Browser with recipe support #74

Closed phenaproxima closed 1 month ago

phenaproxima commented 1 month ago

This PR installs Project Browser by default in Starshot, patching it with https://www.drupal.org/project/project_browser/issues/3446257 so that it displays recipes, plus the commands to install them.

Right now, it only shows starshot_multilingual -- which is no longer installed with Starshot by default. We can show all the recipes in Starshot once we have a reliable way to display whether they've been previously applied or not.

pameeela commented 1 month ago

Tested this manually, and it works, but.... 1) I wasn't expecting it to hijack PB and only show this one recipe, so it kind of ruins PB for Starshot and 2) the suggested command was not valid using the suggested ddev install command for setup.

The suggested command was /usr/bin/php /var/www/html/web/core/scripts/drupal recipe /var/www/html/recipes/starshot_multilingual

I'm not really sure what to suggest though, there probably isn't a way to get it exactly right for everyone? Do we want to worry about this?

The disabling of PB is probably more of a concern.

phenaproxima commented 1 month ago

the suggested command was not valid using the suggested ddev install command for setup.

Yeah, your assessment is correct. You would need to run that command from inside the DDEV container. However, that's a preexisting problem; Project Browser has no way to detect reliably if we're running within DDEV, and even if it did, it can't reliably generate the correct commands. You'd have the same problem if you were browsing regular modules. This problem will be fixed once Project Browser can actually apply recipes in the UI - which is a goal, but it's a bit of a ways off because there is a sizable chunk of work needed in Project Browser to make that work.

I think we probably just want to document this limitation under "Known issues and workarounds" in the README. We can explicitly tell people that, if they're using DDEV, they'll want to SSH into the container to run the Project Browser commands.

I'm a bit confused when you say PB is "disabled"; this doesn't (shouldn't?) disable anything, it just adds recipes as a type of project to be browsed. I'll see what I can do about that. Fixed that in fed0192e16fc87a9293f87e2a0ee4998354e0e21.

phenaproxima commented 1 month ago

I wasn't expecting it to hijack PB and only show this one recipe

Fixed this in fed0192e16fc87a9293f87e2a0ee4998354e0e21.

phenaproxima commented 1 month ago

I've also added something to the README explaining how to run Project Browser commands in DDEV. It's actually pretty straightforward; just run ddev ssh first. Fixed in 91aefeadb6cdf10490201a6dd66ce986ee777034.