search

phenax / bsp-layout

Manage layouts in bspwm (tall and wide)
MIT License
373 stars 30 forks source link

A couple of fixes #32

Closed darkelectron closed 2 years ago

phenax commented 3 years ago

@darkelectro I'm currently unable to test the fix out. Will merge once that's done.

darkelectron commented 3 years ago

Alright. Forgot to mention that this may resolve #20

Worked without the --master-size on my end.

darkelectron commented 3 years ago

This new PR fixes #12. It recalculates whenever one focuses on that particular desktop.

darkelectron commented 3 years ago

ping @phenax

no3m commented 2 years ago

applied the changes to local script from PR 1a18d8a and was still getting goofy behavior when opening new floating windows or un-hiding floating windows... sometimes the layout and the floating window were un-effected; other times, either the tiled layout got messed up or one dimension of the floating window would be reduced to zero (basically just borders visible).

Found this from another fork: https://github.com/floscr/bsp-layout/commit/413ce6ffda668cfd972860357fd4b9d7de0eb00d

adding .!floating to the node_filter in the layouts where applicable seems to help, nothing strange observed so far, but need to test more....

no3m commented 2 years ago

still cases where changes based on PR and .!floating filter fail. Example:

set 'tall' (maybe others) layout on desktop, open ONE terminal... now launch an application w/ state=floating rule (lxappearance tested). The floating window gets squashed to zero width dimension (height unchanged).

Things seem normal when two or more tiled windows are open.

darkelectron commented 2 years ago

I think it depends on the floating app. Haven't been able to reproduce though.

amtoine commented 2 years ago

Doesn't seem to have fixed the floating issue.

i confirm that the problem still is present. i do not have the exact same bug as in #20, but the floating window sometimes gets included in the background tilling :thinking:

see this clip the last floating window, when removing the main window in the rtall layout,, i.e. the one to the right labeled "monferno", gets squished to the right as if it was the new main frame

amtoine commented 2 years ago

and apart from that, i have to admit i'm not sure what this PR is doing...

@darkelectron, do you still have in mind what you wanted to do here? that would be really great to help me figure out why the floating bug isn't resolved :yum:

amtoine commented 2 years ago

Hi @darkelectron :wave: :yum:

as this PR has ben stale for more than a year now, we've decided with @phenax to move the changes to a2n-s/ignore and apply the requested changes there :+1:

hope you'll understand :wink: