search

phenax / bsp-layout

Manage layouts in bspwm (tall and wide)
MIT License
375 stars 30 forks source link

kill subscriber process when desktop is removed #36

Closed no3m closed 2 years ago

no3m commented 3 years ago

change the way kill_layout gets called... desktop options in remove_listener have to be cleared before calling kill_layout, otherwise if remove_listener is called by the subscriber process on desktop_remove event, it will kill itself before the options are cleared.

added 'did' (desktop id) option... once desktop_remove event is triggered, get_desktop_name_from_id is useless since desktop doesn't exist anymore.

amtoine commented 2 years ago

@phenax, in case @no3m does not respond, would you like me to try to fix the requests you made on the commit? :yum:

not sure how that can be done though as i won't be able to push to no3m:master :thinking:

amtoine commented 2 years ago

Hi @no3m :wave: :yum:

as this PR has ben stale for almost 8 months now, we've decided with @phenax to move the changes to a2n-s/kill-subscriber-process-when-desktop-is-removed and apply the requested changes there :+1:

hope you'll understand :wink: