phenax / bsp-layout

Manage layouts in bspwm (tall and wide)
MIT License
373 stars 30 forks source link

fix: calculates layout on desktop focus #50

Closed phenax closed 2 years ago

phenax commented 2 years ago

Fixes #49, #44 and #12

amtoine commented 2 years ago

Count on me to review the changes and test the fixes for the issues you mention :yum:

i'll do that as soon as possible, i.e. after work :ok_hand:

amtoine commented 2 years ago

i did verify that i was able to reproduce all the above issues on master and i am

EDIT: i used make PREFIX=$PWD/build install to build the script in the repo directory and ./build/bin/bsp-layout to be able to swithc quickly from master to fix/issue-49-layout-on-desktop-focus :yum:

switching to fix/issue-49-layout-on-desktop-focus, #44 appears to be gone as i do not have the No such file or directory error when using bsp-layout once on an unfocused desktop :tada:

however, when i:

i still need to focus desktop 2 to apply the layout :thinking: and i've got a 2 monitor setup, so i can see that it does not apply directly :confused:

amtoine commented 2 years ago

my bad @phenax, i misunderstood the issue and the fix! i thought the layouts should apply instantly, even on unfocused desktops, but that's not the point of this PR :slightly_smiling_face:

before the fix, once does not work at all on an unfocused desktop and set requires to switch to the desktop and produce either the node_add, the node_remove or the node_transfer event from bspc

now, the layout applies as soon as the desktop has focus! :tada:

that is a fix by my side :ok_hand:

phenax commented 2 years ago

@a2n-s, fixed a minor issue, can you approve again?