kill subscriber process when desktop is removed

phenax / bsp-layout

Manage layouts in bspwm (tall and wide)

MIT License

375 stars 30 forks source link

Open amtoine opened 2 years ago

amtoine commented 2 years ago

This is a duplicate of the stale #36 to apply the requested changed and merge the branch to master.

amtoine commented 2 years ago

TODO:

[x] make desktop_id=$(bspc query -D -d "$selected_desktop"); a standalone function inside utils/desktop.sh (see 36#discussion_r895042042)
[x] "_have 2 functions kill_layout and kill_process_" (see 36#discussion_r895042221)

amtoine commented 2 years ago

@phenax would you like me to apply the changes above from the original PR, without a review? or wrap them inside a review first?

no pressure if you do not have the time, that's just a friendly ping :relieved:

phenax commented 2 years ago

@amtoine, I think it's better if this pr contains those changes before the review if that's what you mean

amtoine commented 2 years ago

@amtoine, I think it's better if this pr contains those changes before the review if that's what you mean

it was my question :yum:

so i'll add the changes and ping you when i'm done :wink:

amtoine commented 2 years ago

@phenax the first point should be addressed in b38e145c and the second in 3186fc79 :yum: EDIT: and a bad typo below :eyes:

review can begin :muscle: