phenax / bsp-layout

Manage layouts in bspwm (tall and wide)
MIT License
375 stars 30 forks source link

Remove the `;` at the end of the lines (just a question) #64

Closed zakariaGatter closed 2 years ago

zakariaGatter commented 2 years ago

i used bsp-layout and i love it

after checking the source code i find out that you use ; at the end of the line

But bash don't need it. So i want to ask you to create a pull request to improve the script

thank you again

amtoine commented 2 years ago

hi @zakariaGatter :wave:

i used bsp-layout and i love it

glad you like the project :relieved: :star_struck:

after checking the source code i find out that you use ; at the end of the line

you are right on that :thinking: and there might be lines missing the ; at the end too... :confused:

just being curious, is there a rule or a standard pushing people not to use ; at the end of the lines? :yum:

So i want to ask you to create a pull request to improve the script

i can submit something for sure and see if @phenax is up with merging that in the code base :wink:

zakariaGatter commented 2 years ago

just being curious, is there a rule or a standard pushing people not to use ; at the end of the lines? 😋

no there is no standerd just to make script look clean and not confuse newcomers

Also ; only used if you want to Execute Two Commands in the same line so add it at the end is pointless

if you want i can do the changes and made a pull request and if not satisfied we can ignore it

amtoine commented 2 years ago

no there is no standerd just to make script look clean and not confuse newcomers

looks sensible to me :ok_hand:

Also ; only used if you want to Execute Two Commands in the same line so add it at the end is pointless

if you want i can do the changes and made a pull request and if not satisfied we can ignore it

i'm almost done with it, do not worry with that :wink:

amtoine commented 2 years ago

And there it is :wink:

do not hesitate to point out ; i could have missed :+1:

zakariaGatter commented 2 years ago

what you did is wanderful everything look good and clean 👍🏻

amtoine commented 2 years ago

what you did is wanderful everything look good and clean 👍🏻

cool :yum: