Closed zakariaGatter closed 2 years ago
hi @zakariaGatter :wave:
i used
bsp-layout
and i love itglad you like the project :relieved: :star_struck:
after checking the source code i find out that you use
;
at the end of the lineyou are right on that :thinking: and there might be lines missing the
;
at the end too... :confused:
just being curious, is there a rule or a standard pushing people not to use ;
at the end of the lines? :yum:
So i want to ask you to create a pull request to improve the script
i can submit something for sure and see if @phenax is up with merging that in the code base :wink:
just being curious, is there a rule or a standard pushing people not to use ; at the end of the lines? 😋
no there is no standerd just to make script look clean and not confuse newcomers
Also ;
only used if you want to Execute Two Commands in the same line so add it at the end is pointless
if you want i can do the changes and made a pull request
and if not satisfied we can ignore it
no there is no standerd just to make script look clean and not confuse newcomers
looks sensible to me :ok_hand:
Also
;
only used if you want to Execute Two Commands in the same line so add it at the end is pointlessif you want i can do the changes and made a
pull request
and if not satisfied we can ignore iti'm almost done with it, do not worry with that :wink:
And there it is :wink:
do not hesitate to point out ;
i could have missed :+1:
what you did is wanderful everything look good and clean 👍🏻
what you did is wanderful everything look good and clean 👍🏻
cool :yum:
i used
bsp-layout
and i love itafter checking the source code i find out that you use
;
at the end of the lineBut bash don't need it. So i want to ask you to create a
pull request
to improve the scriptthank you again