Open Nonetss opened 3 months ago
i'm not sure i'll have time to review this anytime soon...
however, i'm pretty impressed by the look of this menu of yours, well done :clap: :clap:
This looks incredible! Although I'm not sure if adding rofi as a dependency for users who don't use it is a good idea. I think this should be a separate tool.
This would also be a great candidate for an external module that integrates with bsp-layout. For example, this command can be a separate package called bsp-layout-select
and in bsp-layout
, we can translate any call to bsp-layout some-module
to bsp-layout-some-module
like git does.
This has the advantage of not forcing a dependency on users and instead letting users opt-in to an external module by installing that package. @amtoine, what do you think?
Yes, I thought the same thing. In fact, on my computer, I have it implemented through an external script that I access from sxhdk to modify the layout. But since it seemed like a useful tool that people might find interesting, I decided to try incorporating it into the original project. The script is essentially what I have added to your repository. But if you want to take a look, I have it uploaded to this repo: https://github.com/Nonetss/sxhd-config in the scripts folder.
@phenax, that sounds perfect to me :ok_hand:
This pull request introduces a new command, bsp-layouts select, aimed at enhancing accessibility when switching between different layouts. Upon executing this command, a Rofi menu will appear containing all the available layout types. This approach simplifies the process of changing layouts, making it more intuitive and user-friendly.