phenax / bsp-layout

Manage layouts in bspwm (tall and wide)
MIT License
373 stars 30 forks source link

Inconsistent behavior with --master-size flag #76

Open marcxjo opened 2 months ago

marcxjo commented 2 months ago

What did you expect to happen?

When I set a layout with the --master-size flag set, I expect the master window to occupy a section of the window that takes up that percentage of the area.

What actually happened?

I ran the following sequence of commands on a workspace called I. Before the tall layout was set, the workspace was configured with default bspwm tiling behavior. The workspace was typically tested with a configuration of four terminal windows (hence measurements below given in terms of monospace characters.)

Trying again with a fractional representation of the same value:

Describe your attempts to resolve the issue

I reverted the removal of bc to handle the calculation of the master window size. This appears to be the fix; I'll push a PR shortly after posting this bug.

Steps to reproduce

See the above answer to the question "What actually happened?"

System Information

Installed bsp-layout using a modified AUR PKGBUILD to use latest master commit.

OS arch:

$ uname -osrm
Linux 6.9.4-arch1-1 x86_64 GNU/Linux