Allow support for react-router

phenax / plasmajs

An isomorphic nodeJS framework based on react

Apache License 2.0

134 stars 12 forks source link

Allow support for react-router #2

Open phenax opened 6 years ago

phenax commented 6 years ago

The current implementation for router is pretty shit. I wrote all of that because I couldn't find a good isomorphic solution for it. React-router is much more powerful, flexible and will fit this use case.

hibaAkroush commented 6 years ago

I can do it

passionInfinite commented 6 years ago

@phenax Is this issue still pending I want to contribute to it. Give me more info so that I can contribute. Thank you :)

phenax commented 6 years ago

@passionInfinite, This issue was created because the Router component that is exported in the package is pretty outdated and not something anyone wants to maintain. I was wondering if we could try using react-router as it is far more powerful. From react-router we'll be using MemoryRouter on the server and BrowserRouter on the client side.

An even better case would be if we were to make the existing router an opt-in and provide a way for the developer to plug their own router in. So instead of us shipping a router, we'll instead rely on the consumer of the framework to use the router of their choice.

amaankulshreshtha commented 6 years ago

@phenax I checked the router component, and I am not quite sure I get the requirement. If you could give a little clarity on your comment, that'd be great !! ^^....as in what exactly do you have in mind when you say that the existing router could be made an opt-in.

phenax commented 6 years ago

@AmaanKulshreshtha. The picture I had in mind was that we'd export the the router as it is but we'd provide support for other router implementations like react-router. So the user will be allowed to use a router of their choice and the existing router won't break.

sambhav2448 commented 4 years ago

I wanna work on this

phenax commented 4 years ago

You can go ahead and try but this is a pretty outdated repository. Not sure if it'll be a fun time for you.

If you're looking for open source projects to contribute to, you can pick one of these -

https://github.com/phenax/enum-fp/issues/8 (JS and a little bit of pure functional programming)
https://github.com/phenax/pattern-lock-js/issues/15 (React wrapper for this JS library)
https://github.com/phenax/use-tiny-state-machine/issues/3 (JS and Finite state machine)

Let me know if you need any help :)