Closed ferenc-hechler closed 3 years ago
Hi @ferenc-hechler thanks for opening a PR!
Just a heads up that it's probably going to be the weekend before I can get around to reviewing this.
One comment though...I would be interested in exploring if this can be added in a way that can work with the "MAPS" mode instead of having an explicit mode to its own. I think there's some potential for this to be useful along with a mix of normal map configurations.
Maybe there's a way to add a new map syntax or adapt the existing syntax used for library level image maps in some way.
Thoughts?
Hi @phenixblue,
thanks for your answer. Of course, this feature can be implemented by extending the existing mapping config syntax to mark entries to be handled only as EXACT matches. Internally those entries should be handled in a separate dictionary to avoid confusion. I will update the PR before weekend. :-)
I will start with the following syntax:
[EXACT]<source>::<target>
Feel free to make better suggestions.
I also just noticed your target branch was my feature branch. I just merged #50 into master
. Would you mind correcting that/rebasing to target master
so CI can kick in and run the checks as well?
Rebase sounds difficult, I will create a new PR, then we can reject this one.
Created a replacement for this PR: #54
What type of PR is this?
/kind feature
What this PR does / why we need it:
See ISSUE #51
Which issue(s) this PR fixes:
Fixes #51
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., usage docs, etc.: