search

phenixblue / imageswap-webhook

Image Swap Mutating Admission Webhook for Kubernetes
Apache License 2.0
154 stars 53 forks source link

imageswap-init should use v1 of CertificateSigningRequest instead of v1beta1 #57

Closed carlosonunez closed 2 years ago

carlosonunez commented 2 years ago

What happened: imageswap-init fails to run in Kubernetes v1.22+ due to v1beta1/CertificateSigningRequest having been removed.

What you expected to happen: imageswap-init to start.

How to reproduce it (as minimally and precisely as possible):

  1. Create a Kind cluster running k8s v1.22+: kind create cluster --image=kindest/node:v1.22.4
  2. Install imageswap: kubectl apply -f https://raw.githubusercontent.com/phenixblue/imageswap-webhook/v1.3.0/deploy/install.yaml
  3. See it burn: watch -n 0.5 kubectl get all --namespace=imageswap-system

Anything else we need to know?:

This should just be a s/v1beta1/v1/g inside of imageswap_init.py. I apologize for not having cut the PR myself; I will do so when time allows.

Environment:

Client Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.4", GitCommit:"b695d79d4f967c403a96986f1750a35eb75e75f1", GitTreeState:"clean", BuildDate:"2021-11-17T15:41:42Z", GoVersion:"go1.16.10", Compiler:"gc", Platform:"darwin/amd64"}
phenixblue commented 2 years ago

This change will have some dependencies on bumping KinD node images for CI, and potentially some other items required to support k8s 1.22+. This is more than just a simple version swap.

k8s v1.22 is not officially supported until this is complete.

Opened #62 to track adding a compatibility matrix to the README to show which versions of K8s are supported.

carlosonunez commented 2 years ago

Completely fair. Thanks for an awesome tool! On Jan 10, 2022, 16:43 -0600, Joe Searcy @.***>, wrote:

This change will have some dependencies on bumping KinD node images for CI, and potentially some other items required to support k8s 1.22+. This is more than just a simple version swap. k8s v1.22 is not officially supported until this is complete. Opened #62 to track adding a compatibility matrix to the README to show which versions of K8s are supported. — Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you authored the thread.Message ID: @.***>

bs-matil commented 2 years ago

@phenixblue are you actively working on the project? Do you need assistance on this topic?

phenixblue commented 2 years ago

Yes, the project is active.

@mariomcosta is currently working on this particular issue.