phenobarbital / myroundcube

Automatically exported from code.google.com/p/myroundcube
0 stars 0 forks source link

[google_ads] Add option to NOT have an annoying popup #808

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Token: e8aea4ac80c3e9dc61559039f538d73f (Don't modify this token!)
Version: 3.3.17 (24-02-2015)
PHP: 5.4.16
RCMAIL: 1.1.0
Database: mysql
SERVER: nginx/1.7.10
----
I.  Issue Description: Should have an option NOT to have the annoying error 
message if an adblocker is present

II. Steps to reproduce the Issue:
1. Enable an adblocker
2. Run google ads
3. Be annoyed!

If people want to run an adblocker, I'm fine with that.  I don't want my users 
being pissed off or having to do special things to NOT get annoyed when I am 
using google ads.  I'm fine with losing a little ad revenue because a user has 
an ad blocker.

For now I hacked the code locally so that it won't show the annoying popup if 
adblock is enabled.

Original issue reported on code.google.com by pel...@gmail.com on 14 Apr 2015 at 7:14

GoogleCodeExporter commented 9 years ago
WONTFIX. If admins run the plugin they want people to see ads and not to use an 
ads blocker.

This is a bug tracker and not a support forum or a place to post feature 
requests. Please use https://forum.myroundcube.com in future.

Also please note, that an ads blocker can break the entire interface if it just 
strips off part of the javascript from the HTML output.

Over all, people should be nagged to disable the ads blocker. If you want 
people give the option not to see ads (except on logon screen). Then use Plugin 
Manager and configure the plugin so that it can be disabled by the user.

Your hack is definitely a bad idea.

Original comment by roland.l...@gmail.com on 15 Apr 2015 at 3:51