search

phenology / springtime

Spatiotemporal phenology research with interpretable models
https://springtime.readthedocs.io
Apache License 2.0
3 stars 2 forks source link

sdist contains uncommited files #181

Open sverhoeven opened 10 months ago

sverhoeven commented 10 months ago

Running hatch build creates a dist/springtime-0.1.0.tar.gz file. If your local cloned repo is not clean then the tarball will contain uncommitted files.

For example I had copy of /tmp/data that was included in the tarball. (this was from before #178).

We should change the hatch config so only files under version control are included. Or have a CI workflow to publish to PyPI.

Peter9192 commented 10 months ago

Thanks for spotting and pointing that out! Would it be enough if we only include the source dir, e.g. using the packages option?

Peter9192 commented 10 months ago

I suppose we need to update the license section of the metadata in pyproject.toml

Peter9192 commented 10 months ago

If we tinker with this, we might also think about the inclusion of (example) recipes in the distribution. See https://github.com/phenology/springtime/pull/164#discussion_r1293366168