phenom4n4n / phen-cogs

My public cogs for Red, Discord bot.
https://phen-cogs.readthedocs.io/en/latest/
MIT License
120 stars 71 forks source link

Return in [p]prefix remove #59

Closed Ryan5453 closed 3 years ago

Ryan5453 commented 3 years ago

I haven't tested this but there's no reason it shouldn't work ¯_(ツ)_/¯

sourcery-ai[bot] commented 3 years ago

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 1.95 ⭐ 1.95 ⭐ 0.00
Method Length 44.93 ⭐ 44.93 ⭐ 0.00
Working memory 7.53 🙂 7.53 🙂 0.00
Quality 78.38% 78.38% 0.00%
Other metrics Before After Change
Lines 172 172 0
Changed files Quality Before Quality After Quality Change
prefix/prefix.py 78.38% ⭐ 78.38% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
prefix/prefix.py Prefix.prefix_embed 8 ⭐ 93 🙂 10 😞 62.13% 🙂 Extract out complex expressions
prefix/prefix.py Prefix.prefix_set 1 ⭐ 81 🙂 10 😞 70.71% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

phenom4n4n commented 3 years ago

Thanks!