phenom4n4n / phen-cogs

My public cogs for Red, Discord bot.
https://phen-cogs.readthedocs.io/en/latest/
MIT License
120 stars 71 forks source link

Add command to edit the tagscript from pastebin link #86

Closed sravan1946 closed 3 years ago

sravan1946 commented 3 years ago

couldn't name the command append cuz it was already used in the cog.¯\(ツ)

flaree commented 3 years ago

Just a comment while I seen this. Requests is blocking, you should use aiohttp for all requests as it's async. This applies to more than just this PR and isn't a review of any sort.

sravan1946 commented 3 years ago

Just a comment while I seen this. Requests is blocking, you should use aiohttp for all requests as it's async. This applies to more than just this PR and isn't a review of any sort.

i'm new in python and these stuff 😅

phenom4n4n commented 3 years ago

Thanks for opening this PR. I have a few requests for changes that should be made, but I'll post them here rather than in a review and make the changes myself.

phenom4n4n commented 3 years ago

I messed up git so I'll PR it myself. In the future, make sure to create a new branch to make pull requests from.