Closed sravan1946 closed 3 years ago
Just a comment while I seen this. Requests is blocking, you should use aiohttp for all requests as it's async. This applies to more than just this PR and isn't a review of any sort.
Just a comment while I seen this. Requests is blocking, you should use aiohttp for all requests as it's async. This applies to more than just this PR and isn't a review of any sort.
i'm new in python and these stuff 😅
Thanks for opening this PR. I have a few requests for changes that should be made, but I'll post them here rather than in a review and make the changes myself.
Tags.session
rather than requests which is blocking.I messed up git so I'll PR it myself. In the future, make sure to create a new branch to make pull requests from.
couldn't name the command
append
cuz it was already used in the cog.¯\(ツ)/¯