phenomecentre / nPYc-Toolbox

The nPYc-Toolbox defines objects for representing, and implements functions to manipulate and display, metabolic profiling datasets.
MIT License
24 stars 8 forks source link

Feature/fix unit tests #96

Closed gordondavies closed 1 year ago

gordondavies commented 1 year ago

There are 6 unit tests failing in the develop branch that are due to changes in underlying library APIs (matplotlib).

Changes:

setup.py matplotlib==3.5.2 markupsafe==2.01

plotloadinds uses the new matplotliv API style, and updated seaborn JointGrid to use a pandas dataframe and the height param (was called 'size').

Updated the featureIDreport to use sns.scatterplot instead of plt.scatter to overcome the other failing unit test

codecov[bot] commented 1 year ago

Codecov Report

Base: 76.95% // Head: 77.18% // Increases project coverage by +0.22% :tada:

Coverage data is based on head (30b65e5) compared to base (005047b). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #96 +/- ## =========================================== + Coverage 76.95% 77.18% +0.22% =========================================== Files 76 76 Lines 11562 11562 Branches 2289 2272 -17 =========================================== + Hits 8898 8924 +26 + Misses 1938 1904 -34 - Partials 726 734 +8 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `77.18% <100.00%> (+0.22%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=phenomecentre#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/phenomecentre/nPYc-Toolbox/pull/96?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=phenomecentre) | Coverage Δ | | |---|---|---| | [nPYc/plotting/\_multivariatePlotting.py](https://codecov.io/gh/phenomecentre/nPYc-Toolbox/pull/96?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=phenomecentre#diff-blBZYy9wbG90dGluZy9fbXVsdGl2YXJpYXRlUGxvdHRpbmcucHk=) | `78.81% <100.00%> (+0.37%)` | :arrow_up: | | [nPYc/reports/featureID.py](https://codecov.io/gh/phenomecentre/nPYc-Toolbox/pull/96?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=phenomecentre#diff-blBZYy9yZXBvcnRzL2ZlYXR1cmVJRC5weQ==) | `68.54% <100.00%> (ø)` | | | [nPYc/multivariate/multivariateUtilities.py](https://codecov.io/gh/phenomecentre/nPYc-Toolbox/pull/96?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=phenomecentre#diff-blBZYy9tdWx0aXZhcmlhdGUvbXVsdGl2YXJpYXRlVXRpbGl0aWVzLnB5) | `81.69% <0.00%> (-1.41%)` | :arrow_down: | | [nPYc/reports/multivariateReport.py](https://codecov.io/gh/phenomecentre/nPYc-Toolbox/pull/96?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=phenomecentre#diff-blBZYy9yZXBvcnRzL211bHRpdmFyaWF0ZVJlcG9ydC5weQ==) | `57.46% <0.00%> (+5.56%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=phenomecentre). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=phenomecentre)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

gordondavies commented 1 year ago

Merging PR into develop