phenomnomnominal / betterer

betterer makes it easier to make incremental improvements to your codebase
MIT License
569 stars 38 forks source link

CLI output is confusing when only file hashes have changed #1184

Open camjackson opened 4 months ago

camjackson commented 4 months ago

As described in this discord message, betterer in CI mode can be confusing when the only mismatch is the file hash, and not the issues in a file.

In this situation, betterer will say:

All checks stayed the same

... followed immediately by:

Unexpected changes detected in these tests...

Ideally it would say something like:

All checks stayed the same, however, the file hash has changed for path/to/file.txt. Please re-run betterer locally to update all file hashes in betterer.results.

I'm going to see if I can fix this and open a PR...