search

phenopackets / hapi-pheno

FHIR Client for working with phenopackets
http://phenopackets.org/hapi-pheno/
GNU General Public License v3.0
3 stars 0 forks source link

Module refactor #22

Closed pnrobinson closed 2 years ago

pnrobinson commented 2 years ago

Not ready for merge -- see issues. @chrisroederucdenver -- something is not working in the logging configuration

chrisroederucdenver commented 2 years ago

I’m guilty of noticing something about logging not working and “printlning” my way around it.

From: Peter Robinson @.> Date: Monday, September 12, 2022 at 3:14 PM To: pnrobinson/hapi-pheno-client @.> Cc: Roeder, Chris3 @.>, Mention @.> Subject: Re: [pnrobinson/hapi-pheno-client] Module refactor (PR #22) [External Email - Use Caution]

Not ready for merge -- see issues. @chrisroederucdenverhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fchrisroederucdenver&data=05%7C01%7Cchris.roeder%40cuanschutz.edu%7Cf5447dc469ab475280a408da9503d6ea%7C563337caa517421aaae01aa5b414fd7f%7C0%7C0%7C637986140966249511%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=8F6x6auXrId4BBMpIYieTzMjszecIqfHaFQAmmWd0Ds%3D&reserved=0 -- something is not working in the logging configuration

— Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fpnrobinson%2Fhapi-pheno-client%2Fpull%2F22%23issuecomment-1244486350&data=05%7C01%7Cchris.roeder%40cuanschutz.edu%7Cf5447dc469ab475280a408da9503d6ea%7C563337caa517421aaae01aa5b414fd7f%7C0%7C0%7C637986140966249511%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=69hSFflh%2FxmMPCUyuct7F%2FYTOIjhgWnUWbuIfQBh9qI%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FALG3NFKIQWS6RU7UVJONVHTV56MM5ANCNFSM6AAAAAAQK25RZI&data=05%7C01%7Cchris.roeder%40cuanschutz.edu%7Cf5447dc469ab475280a408da9503d6ea%7C563337caa517421aaae01aa5b414fd7f%7C0%7C0%7C637986140966249511%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=vTSTVpFdKv9C5uJFvdCBUImRs8RP%2B9JFf4mllUwSv5I%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

pnrobinson commented 2 years ago

@chrisroederucdenver @ShahimEssaid -- I fixed the logging/testing issues and think we can merge. I would suggest we then change the name of the project to hapipheno and add the hapi server starter as a new module to this project.