phenopackets / phenopacket-format

26 stars 10 forks source link

Add version info to JSON Schema, and implement a procedure to ensure in sync with reference implementation #60

Open cmungall opened 8 years ago

cmungall commented 8 years ago

Currently the JSON-Schema is purely derived. The procedure is to run SchemaGeneratorTest in the reference implementation. The Makefile in this repo copies this across. This is potentially confusing, things can get out of sync.

In many ways a merger of the two repos might make some of this easier

harryhoch commented 8 years ago

@cmungall. Thanks. Agreed that some cleanup might be helpful. for now, it seems like the workflow should be as follows:

  1. mvn package on the reference implementation repository
  2. in phenopacket-format run make (or make json-schemas).

Is this correct? How does one run SchemaGeneratorTest and is it needed given the above?

cmungall commented 8 years ago

Yes, that's right

I run SchemaGeneratorTest from within eclipse, but you can just do mvn test.

harryhoch commented 8 years ago

got it. thanks