phenopackets / phenopacket-python

8 stars 3 forks source link

Adding environments to the schema? #6

Open austinmeier opened 6 years ago

austinmeier commented 6 years ago

We are attempting to modify the phenopacket format to allow us to describe environments using specific attributes (temp, humidity, pressure, light, etc...) and have a mock up of an environment that can be found here:

https://github.com/phenoscape/EnviroPackets/blob/master/hadalpelagic_zone.json

However, when attempting to validate the test packet, we run into this error:

Invalid phenopacket found in  ~/git/EnviroPackets/hadalpelagic_zone.json
'environment' is not one of ['disease', 'organism', 'patient', 'variant', 'genotype', 'paper']

It's pretty clear that an environment is not one of those options, so my assumption is that we need to add a "type" to the possible options? I do not see these classes defined in the schema.

@cmungall