phenopackets / phenopacket-reference-implementation

Reference java implementation for phenopackets
BSD 3-Clause "New" or "Revised" License
6 stars 9 forks source link

Added contributor and date fields to associations. #76

Closed balhoff closed 8 years ago

balhoff commented 8 years ago

This addresses #69. The results look like this:


---
id: "http://model.geneontology.org/ec9502c7-dfc5-45b0-9208-db22db2497bc"
title: "OMIM-100800.tsv"
diseases:
- id: "http://purl.obolibrary.org/obo/OMIM_100800"
  label: "ACHONDROPLASIA"
'@context': "http://phenopackets.org/context"
phenotype_profile:
- entity: "http://purl.obolibrary.org/obo/OMIM_100800"
  phenotype:
    types:
    - id: "http://purl.obolibrary.org/obo/HP_0003032"
      label: "Short femoral neck"
  evidence:
  - types:
    - id: "http://purl.obolibrary.org/obo/ECO_0000501"
      label: "IEA"
  contributor: "http://orcid.org/0000-0002-0736-9199"
  date: "2009-02-17"

What do you think @cmungall?

One issue unrelated to the format design is that there is an awful lot of duplicated code between the different types of associations. Not sure of the best design with the builders, etc.