phenopackets / phenopacket-schema

Repository for the GA4GH phenopacket schema
https://phenopacket-schema.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
75 stars 28 forks source link

Proposed Interval for time duration #246

Closed rrfreimuth closed 3 years ago

rrfreimuth commented 3 years ago

Please note that the GKS VRS defines classes that represent the concept of an Interval (which is an abstract, base class) on a molecular sequence. At a minimum, please qualify the name of the proposed Interval class so that it does not create confusion with the VRS.

Please also consider aligning to the FHIR representation of time duration, which is modeled as Period . The core datatype is dateTime . Types for date and time are also available.

The Domain Analysis and mapping to FHIR document has analysis on this particular type, as it pertains to the concept of patient Age.

pnrobinson commented 3 years ago

@rrfreimuth do you have a suggestion for labvelling https://phenopackets-schema.readthedocs.io/en/latest/interval.html ? It seems that there is a natural translation from Period to this Interval. What additional steps are needed to align it?

pnrobinson commented 3 years ago

Here is a description from a forum: "Period" is a length of time, without the necessary implication of recurrence. "Interval" more often implies the length of time between two actions.

So, it does seem that "Period" is a better label for this element, especially because is named so in FHIR

pnrobinson commented 3 years ago

However, a period is not anchored to a specific start/end

pnrobinson commented 3 years ago

Let's rename to TimeInterval which is the most unambiguous label -- it is intended to be synonymous with the FHIR Period.