phenopackets / phenopacket-tools

An app and library for building, conversion, and validation of GA4GH Phenopackets.
http://phenopackets.org/phenopacket-tools/stable/
GNU General Public License v3.0
12 stars 5 forks source link

use uniform UCUM encoding (either slash or dot notation but not both) #131

Closed cmungall closed 1 year ago

cmungall commented 1 year ago

We have a mix:

ontology.id ontology.label variable.name function.name
UCUM:mg/dL milligram per deciliter MILLIGRAM_PER_DL milligramPerDeciliter
UCUM:mg.kg-1 milligram per kilogram MILLIGRAM_PER_KG mgPerKg

I suggest writing all one way. I slightly prefer the dot notation as that is what is normalized to in https://units-of-measurement.org/

Specifically:

  1. switch / to exponents
  2. sort by exponent, from positive to negative
  3. when the exponent is the same, sort alphabetically