search

phenopackets / phenopacket-tools

An app and library for building, conversion, and validation of GA4GH Phenopackets.
http://phenopackets.org/phenopacket-tools/stable/
GNU General Public License v3.0
12 stars 5 forks source link

UCUM codes should be prefix encoded #135

Closed cmungall closed 1 year ago

cmungall commented 1 year ago

Currently some of the UCUM CURIEs are not valid CURIEs and don't expand to valid URIs.

I suggest adopting percent encoding as specified here: https://build.fhir.org/rdf.html#2.1.6.6.7

cmungall commented 1 year ago

Just pinging on this, it's really important to get this right, it would be bad if units were not interoperable

ielis commented 1 year ago

Hello @cmungall I would like to resolve this issue but I am not sure how to interpret/adopt the percent encoding.

Can you please suggest an example edit?

cmungall commented 1 year ago

see the README here https://github.com/units-of-measurement/units-of-measurement/

ielis commented 1 year ago

Hi @cmungall I think the Unit table contains valid UCUM ids. FWIW, all UCUMs used in phenopacket-tools are present in the mappings table.

Please reopen if you see anything odd in the Unit table. Thanks!