search

phenopackets / phenopacket-tools

An app and library for building, conversion, and validation of GA4GH Phenopackets.
http://phenopackets.org/phenopacket-tools/stable/
GNU General Public License v3.0
10 stars 5 forks source link

Validate ISO8601 period strings #193

Closed ielis closed 11 months ago

ielis commented 11 months ago

As pointed out in #192 , phenopacket-tools does not validate the ISO8601 period strings.

This PR adds the period string validation using a JSONSchema regexp.

pnrobinson commented 11 months ago

@ielis @julesjacobsen We did not specify anything beyond ISO 8601 in the schema. It is probably best for us to allow the time (T...) portion of the string, because we did not say that it was not allowed.