phenopackets / phenopacket-tools

An app and library for building, conversion, and validation of GA4GH Phenopackets.
http://phenopackets.org/phenopacket-tools/stable/
GNU General Public License v3.0
13 stars 5 forks source link

Rename packages to `phenopacket-tools` #48

Closed julesjacobsen closed 2 years ago

julesjacobsen commented 2 years ago

'Phenotools' is, in my opinion, a poor name as it is rather generic and nondescript. Phenopacket-tools is a bit more specific and I suggest we use this. This would require changing the groupId , artifactIds and the package names. It will completely break all existing code, so needs to happen before pushing to maven central.

    <parent>
        <groupId>org.phenopackets.phenotools</groupId>
        <artifactId>phenotools</artifactId>
        <version>0.0.2-SNAPSHOT</version>
    </parent>
    <modelVersion>4.0.0</modelVersion>

    <artifactId>phenotools-builder</artifactId>

@pnrobinson @ielis any objections?

pnrobinson commented 2 years ago

given the domain of phenopackets, we could be a little more concise with

 <parent>
        <groupId>org.phenopackets.tools</groupId>
        <artifactId>phenopacket-tools</artifactId>
        <version>0.0.2-SNAPSHOT</version>
    </parent>

but I agree in any case that phenotools is suboptimal

ielis commented 2 years ago

Sounds good to me, both the new groupId and artifactId an.

julesjacobsen commented 2 years ago

Thanks @pnrobinson - remember to delete all stale branches now and branch from develop!