search

phenopackets / phenopacket-tools

An app and library for building, conversion, and validation of GA4GH Phenopackets.
http://phenopackets.org/phenopacket-tools/stable/
GNU General Public License v3.0
12 stars 5 forks source link

BiosampleConverter #55

Open pnrobinson opened 2 years ago

pnrobinson commented 2 years ago

@julesjacobsen given the lack of strictness in the semantics of version 1 variants, it seems it might be better to emit a warning here that the user will need an implementation specific way of doing this conversion?

if (biosample.getVariantsCount() != 0) {
     // TODO: create an interpretation along with any genes
}
pnrobinson commented 1 year ago

@ielis @julesjacobsen -- we could add this to the conversion and basically just assume that it is causal if people used it in V1 or we could emit a warning and skip things. Thoughts?