search

phenopackets / phenopacket-tools

An app and library for building, conversion, and validation of GA4GH Phenopackets.
http://phenopackets.org/phenopacket-tools/stable/
GNU General Public License v3.0
12 stars 5 forks source link

Further polishing #56

Closed pnrobinson closed 2 years ago

pnrobinson commented 2 years ago

This PR adds the GNU3 licence, adapts the Retinoblastoma example to use string instead of any, and uses the "of" and "builder" names for static functions that return a finished object or a builder. The one exception is ontologyClass which is used so often it is good to make an exception. Otherwise, using this pattern is clearer (i.e., I agree with your suggestion).

julesjacobsen commented 2 years ago

Please don't use GPL-3 it's really not what we want. BSD-3 or MIT would be far more appropriate.

pnrobinson commented 2 years ago

Um, what don;t you like about GNU3? I am a fan of sorts because of the open source virality.

julesjacobsen commented 2 years ago

Like I said in my comment copyleft licences are frequently a blocker for use by commercial entities. It's just a massive pain and prevents easy uptake and adoption.

https://github.com/phenopackets/phenopacket-tools/issues/53#issuecomment-1102879268

julesjacobsen commented 2 years ago

Just found the GA4GH doc on this: https://www.ga4gh.org/wp-content/uploads/GA4GH-Copyright-Policy-Updated-Formatting.pdf

TLDR - Use Apache 2.0

pnrobinson commented 2 years ago

merging all of the new branches