search

phenopackets / phenopacket-tools

An app and library for building, conversion, and validation of GA4GH Phenopackets.
http://phenopackets.org/phenopacket-tools/stable/
GNU General Public License v3.0
13 stars 5 forks source link

Non-private `builder` field in `VariationDescriptorBuilder` #59

Closed ielis closed 2 years ago

ielis commented 2 years ago

Is there a reason why the builder field is package-private in VariationDescriptorBuilder and VariantInterpretationBuilder?

It looks like a bug, I did not find any usages of the inner builders, nor the other inner builders in the same package have package-private access.

pnrobinson commented 2 years ago

Should have been private. Fixed.