search

phenopackets / phenopacket-tools

An app and library for building, conversion, and validation of GA4GH Phenopackets.
http://phenopackets.org/phenopacket-tools/stable/
GNU General Public License v3.0
13 stars 5 forks source link

Unclear `String identifier` argument for `GeneDescriptorBuilder.builder()` and `GeneDescriptorBuilder.of()` #60

Closed ielis closed 2 years ago

ielis commented 2 years ago

Both methods GeneDescriptorBuilder.builder() and GeneDescriptorBuilder.of() take String identifier as a parameter. However, there is no field named identifier in the schema. The parameters should be renamed to String valueId to disambiguate.

pnrobinson commented 2 years ago

Fixed by https://github.com/phenopackets/phenopacket-tools/pull/113