search

phenopackets / phenopacket-tools

An app and library for building, conversion, and validation of GA4GH Phenopackets.
http://phenopackets.org/phenopacket-tools/stable/
GNU General Public License v3.0
12 stars 5 forks source link

Add `AllelicState` into `org.phenopackets.phenopackettools.builder.constants` package? #61

Closed ielis closed 2 years ago

ielis commented 2 years ago

The VariationDescriptorBuilder allows to set the allelicState field via heterozygous(), homozygous() etc. The methods contain hard-coded GENO constants. However, it may be useful to define the allelic state constants in a new org.phenopackets.phenopackettools.builder.constants.AllelicState class.

pnrobinson commented 2 years ago

good suggestion, done!